-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spectrum plotting of data in the Live Viewer via Dask #2336
Open
MikeSullivan7
wants to merge
44
commits into
main
Choose a base branch
from
live_viewer_spectrum_plotting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSullivan7
force-pushed
the
live_viewer_spectrum_plotting
branch
from
November 22, 2024 15:55
e23f8ae
to
a14efd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Progresses #2327
Description
Dask has been used to create a DaskImageDataStack in the Live Viewer Model which lazily loads the incoming images into a Dask Array. This Dask Array is then used to display and do stack-wide operations (i.e. calculate the mean spectrum within an ROI) on the incoming data without having to load the full stack into RAM and could therefore be useful for PCs with low RAM. The Dask-style of handling the data can be toggled on or off by right-clicking the image > Operations > Calculate Spectrum. If the checkbox is unchecked, the Live Viewer falls back to its older functionality.
Testing
Make sure all tests pass
Acceptance Criteria
Open the Live Viewer and point it to a empty test folder, and toggle the Spectrum Calculation on via the right-click menu.
Use the
simulate-live-date.py
script to move images into the test folder and check that the spectrum is calculated and updated with every new image, and it is at a level that you would expect (i.e. verify this with the Spectrum Viewer).While in operation, try moving the ROI and check that the Spectrum is recalculated and updates in the window accordingly.
Documentation
Release note