Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin conda-build #36681

Merged

Conversation

jclarkeSTFC
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC commented Jan 22, 2024

The PR that fixed the massive logs problem has been merged in to conda-build, so the pin can hopefully be removed.

See #36544 for the original pin to avoid massive logs. The issue (conda/conda-build#5106) was fixed in conda-build with conda/conda-build#5108.

Fixes #36551.

To test:

Check that the size of the build logs is similar to those with the pin still in.

This does not require release notes because it only affects build logs


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

The PR that fixed the massive logs problem has been merged in to conda-build,
so the pin can hopefully be removed.
@jclarkeSTFC jclarkeSTFC added Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Dependencies Pull requests that update a dependency file labels Jan 22, 2024
@jclarkeSTFC jclarkeSTFC added this to the Release 6.10 milestone Jan 22, 2024
@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review January 23, 2024 08:54
@thomashampson thomashampson self-assigned this Jan 23, 2024
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packaging environment now installs conda-build 3.28.4, which resolves the issue with huge logs. We can now remove the pin without worrying about clogging up the build servers.

@SilkeSchomann SilkeSchomann merged commit 0605008 into mantidproject:main Jan 23, 2024
9 checks passed
@jclarkeSTFC jclarkeSTFC deleted the 36551_unpin_conda_build branch January 23, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin conda-build in packacge-conda env
3 participants