Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle 23/5 bugfixes and instrument info update #10

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Cycle 23/5 bugfixes and instrument info update #10

merged 9 commits into from
Aug 20, 2024

Conversation

mducle
Copy link
Member

@mducle mducle commented Aug 20, 2024

Updated instrument info parsing:

  • Change data type of chopper speed to float32
  • Fix energy data type (was int32, should have been float32)
  • Parses "rep_xxx" fields in raw nxs correctly, and omits them from nxspe files
  • Removes references to spectra in detector_elements_1 - has only one mapping from detector to workspaces now (workspaces are Horace terms, Mantid calls these spectra).

Other bugfixes:

  • Update new IDAaaS paths (RB/experiment specific)
  • Add a NormaliseByCurrent step to Cd runs
  • Make error message if auto-Ei fails more understandable
  • Remove MARI high instrument background subtraction routines (copy kept in reduction_utils for future info)
  • Add extra try/catch ValueError to handle files which are incompletely written (when using the "wait for file to exist" mode)
  • Fix bug where L2 is obtained from detector which doesn't exist (detector 0 does not always exist).
  • Fix DG_monovan for fixedei=True (port code from DG_reduction)
  • Workaround dodgy LET .raw file loading in DG_whitevan where the file has no monitors

Fix bug in saving powder instrument info
Update to use new DAaaS data paths
Update MARI background scan
MARI Whitebeam vanadium runs with wrong num spectra
Reduction of quiet counts or whitevan will now error
Hopefully fix workspace invalidated error
+ Change data type of chopper speed to float32
+ Fix energy data type (was int32, should have been float32)
+ Parses "rep_xxx" fields in raw nxs correctly,
  and omits them from nxspe files
@mducle mducle merged commit 6127d46 into main Aug 20, 2024
1 check passed
@mducle mducle deleted the cycle235init branch August 20, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant