Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/knn filter #208

Merged
merged 17 commits into from
Feb 12, 2024
Merged

Fix/knn filter #208

merged 17 commits into from
Feb 12, 2024

Conversation

djklim87
Copy link
Contributor

@djklim87 djklim87 commented Feb 8, 2024

No description provided.

@djklim87 djklim87 requested a review from donhardman February 9, 2024 15:07
Copy link
Collaborator

@donhardman donhardman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, just some small changes and missing doc to be fixed

src/Plugin/Knn/Handler.php Show resolved Hide resolved
src/Plugin/Knn/Handler.php Outdated Show resolved Hide resolved
src/Plugin/Knn/Payload.php Outdated Show resolved Hide resolved
src/Plugin/Knn/Payload.php Outdated Show resolved Hide resolved
src/Plugin/Knn/Payload.php Outdated Show resolved Hide resolved
djklim87 added 3 commits February 12, 2024 12:42
# Conflicts:
#	src/Lib/QueryProcessor.php
#	src/Plugin/Knn/Payload.php
@djklim87 djklim87 merged commit 4d05003 into main Feb 12, 2024
3 checks passed
@djklim87 djklim87 deleted the fix/knn-filter branch February 12, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants