Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ext filesystem capabilities #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AidenCohen31
Copy link

No description provided.

@brianhlin
Copy link

@LincolnBryant this is one of our students who's adding some functionality so that we can use this at the CHTC. Who would be a good person to give this a review?

@LincolnBryant LincolnBryant self-requested a review January 3, 2023 23:01
@LincolnBryant
Copy link
Contributor

Sorry it took so long to take a gander at this. I will test it out tomorrow or so! Thank you for the contribution.

@LincolnBryant
Copy link
Contributor

Hi, trying to build this package I'm not having any luck.

[centos@ext-test osgconnect-quota]$ rpm -qa | grep golang
golang-bin-1.18.4-1.el7.x86_64
golang-src-1.18.4-1.el7.noarch
golang-1.18.4-1.el7.x86_64
[centos@ext-test osgconnect-quota]$ go build
# github.com/maniaclab/osgconnect-quota
./qs2.go:213:23: cannot use email (variable of type *string) as type string in argument to utilizationBar
./qs2.go:219:23: cannot use email (variable of type *string) as type string in argument to utilizationBar
./qs2.go:224:23: cannot use email (variable of type *string) as type string in argument to utilizationBar

maybe it ought to be

[centos@ext-test osgconnect-quota]$ git diff
diff --git a/qs2.go b/qs2.go
index 02fa118..ca3317a 100644
--- a/qs2.go
+++ b/qs2.go
@@ -210,18 +210,18 @@ func main() {
                cq := cephQuota(username, *cephPathPtr)
 
                fmt.Printf("%-10s: ", *cephPathPtr)
-               utilizationBar(&cq, email)
+               utilizationBar(&cq, *email)
        }
        if *pathPtr != "" {
                xq := xfsQuota(username, *pathPtr)
 
                fmt.Printf("%-10s: ", *pathPtr)
-               utilizationBar(&xq, email)
+               utilizationBar(&xq, *email)
        }
        if *extPtr != "" {
                eq := extQuota(username, *extPtr)
                fmt.Printf("%-10s: ", *extPtr)
-               utilizationBar(&eq, email)
+               utilizationBar(&eq, *email)
 
        }
 }

Is it working for you @AidenCohen31 ?

@AidenCohen31
Copy link
Author

AidenCohen31 commented Jan 17, 2023 via email

@AidenCohen31
Copy link
Author

finished with my changes, but may need some feedback on if using a sudo command is allowed eg. sudo repquota in order to get ext quotas.

@brianhlin
Copy link

@AidenCohen31 I would assume that this runs as a privileged user so it shouldn't need sudo

@LincolnBryant
Copy link
Contributor

Yep, sudo not needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants