Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TernoScans and ErosScan #7658

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Bazket571
Copy link

No description provided.

@MikeZeDev
Copy link
Contributor

Hello. thanks for your contribution but are you aware those websites change domain like 2 times a week and it will be a pain to maintain ?

If you really want i can review the code, there are quite some things to fix :)

@Bazket571
Copy link
Author

Ofcourse you can review the code, is this what Github was made for?
Not gonna lie I made this for an one time download so I didn't aware they change their domain so frequently, but if we can somehow get the image link directly without the domain regex that would be great.
The image link is stored directly on the website in a script tag starts with ts_reader.run. Its in plain text for Eros but for Terno its in base64
For the site URL, I think all those domains are aliases to each other.

@Bazket571
Copy link
Author

Speak of the devil they just changed their domain

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Jan 12, 2025

  1. Pay attention to indentation, use things like eslint
  2. Those sites use a theme we call "Mangastream" look for similar websites in source code base instead of reinventing the wheel :)

Copy link
Contributor

@MikeZeDev MikeZeDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you do it like other MangaStream websites, and fix that ugly indentation ^^

src/web/mjs/connectors/Erosscan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/Erosscan.mjs Show resolved Hide resolved
src/web/mjs/connectors/Erosscan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/TernoScan.mjs Outdated Show resolved Hide resolved
src/web/mjs/connectors/TernoScan.mjs Outdated Show resolved Hide resolved
@MikeZeDev
Copy link
Contributor

Oh crap we alredy have a

Replace this one.

@Bazket571
Copy link
Author

I think thats a different one. That tecno one is in spanish and this one is in english. Maybe its just tecno in the name, but the eros scan actually refer this as terno 😆

@MikeZeDev
Copy link
Contributor

I think thats a different one. That tecno one is in spanish and this one is in english. Maybe its just tecno in the name, but the eros scan actually refer this as terno 😆

The one i ma referring is dead and i am pretty sure terno was named tecno in the past.
Even according to previous domains. Thats a damn mess anyway, please just replace it so its accurate with Haruneko.

@MikeZeDev
Copy link
Contributor

Trailing "/" still needs to be removed and changes marked as "solved". I know its a bit formal but its a good practice not to let maintainers fix little things on PR ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants