Change event type and log type to structured enum #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruwi-next
force-pushed
the
log-event-type-enum
branch
from
e281db7 to
4603f08
Compare
|
hey @ruwi-next thanks for the PR. |
|
Cool I've resolved the conflicts in a merge commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I think it would make a better interface if we used enums to represent the event type and log type. It also should be more efficient since we are using a pair of enum instead of a string.
We can also more accurately represent the possible states by nesting the log type in the enum variant where it is applicable.
This does make some assumptions about the combination of event type and log type but I think it is correct.
Any feedback is appreciated