Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoders improvements 3 - another batch #46

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Decoders improvements 3 - another batch #46

wants to merge 4 commits into from
+281 −306

Conversation

jrouaix
Copy link
Contributor

@jrouaix jrouaix commented Dec 16, 2024

just some more refacto, mainly on network & opendirectory modules

@jrouaix jrouaix changed the title Decoders improvments3 - another batch Decoders improvements 3 - another batch Dec 17, 2024
puffyCid
puffyCid reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@puffyCid puffyCid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!
Left few comments for very small clippy nitpicks

src/util.rs Show resolved Hide resolved
src/decoders/network.rs Outdated Show resolved Hide resolved
@jrouaix
Copy link
Contributor Author

jrouaix commented Dec 18, 2024

Should be good now, paired with clippy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puffyCid puffyCid puffyCid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrouaix @puffyCid