Fix infinite loop in DNS parsing #38
Merged
+38
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to fix an infinite loop that was seen in the wild when parsing DNS entries from a sample with private data logging enabled. This is due to a lack of verification of the IP type (4 vs 6) with no corresponding
else
block in the subsequent parsing loop. I also took the opportunity to do some minor cleanup, reducing some of the parsing down to one-liners with nom.