Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom Taskbar from breaking on Win 11 #617

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix Custom Taskbar from breaking on Win 11 #617

merged 1 commit into from
Oct 2, 2024

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Sep 13, 2024

This is a 2 fold PR.

  1. This is the first step for addressing the installation failure in Windows 11 as noted here: Error with packages installer.vm #603. This changes the name of our custom start layout to the name that Windows uses when actually implementing the custom layout, which will then be used in (2nd PR here, from VM-Packages) to store it in the correct location.

  2. This also fixes Procmon and Process Explorer duplication in the taskbar as noted in duplication when opening application from taskbar VM-Packages#1100

NOTE: This WILL break the install until the 2nd PR is merged due to the name change for the custom layout.

@@ -910,9 +910,9 @@ $configXml.save((Join-Path ${Env:VM_COMMON_DIR} "packages.xml"))

# Custom Start Layout setup
Write-Host "[+] Checking for custom Start Layout file..."
$layoutPath = Join-Path ${Env:VM_COMMON_DIR} "CustomStartLayout.xml"
$layoutPath = Join-Path "C:\Users\Default\AppData\Local\Microsoft\Windows\Shell" "LayoutModification.xml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emtuls

This changes the name of our custom start layout to the name that Windows uses when actually implementing the custom layout, which will then be used in (2nd PR mandiant/VM-Packages#1137, from VM-Packages) to store it in the correct location.

I do not see that the new filename is used in the second PR. Am I understanding something wrong?

Copy link
Member Author

@emtuls emtuls Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I think I had a different implementation in my head that wasn't actually the route that was taken, so that wording is wrong.

We just need to do change the name and path in this PR and remove the old code in the second PR, since customstartlayout won't exist anymore. 🙂

Copy link
Member

@Ana06 Ana06 Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, I just wanted to confirm it before merging this PR 😉 As the other PR won't find the file used in the removed code, I think we can merge this PR already.

@Ana06 Ana06 merged commit d268ed2 into main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants