Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internet detector tool images #608

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add internet detector tool images #608

merged 1 commit into from
Aug 28, 2024

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Aug 27, 2024

This adds the images required by mandiant/VM-Packages#1121

install.ps1 Show resolved Hide resolved
@emtuls emtuls force-pushed the internet-detector branch 2 times, most recently from a480702 to 8cb1438 Compare August 28, 2024 01:41
Co-authored-by: Ana Martinez Gomez <[email protected]>
@emtuls emtuls force-pushed the internet-detector branch from 8cb1438 to a2dab3d Compare August 28, 2024 04:23
@emtuls
Copy link
Member Author

emtuls commented Aug 28, 2024

Unfortunately, I don't think we can go the route of simply downloading a directory off of github with the images we want all inside. :(
It either needs to be packaged into a single file (like a zip), or we have to iterate through each file we want like we had before.

Someone does maintain a tool that can sort of make it happen, but idk if we want to rely on that or if it works easily (I think it might require a github token, so probably not something we want to consider): https://github.com/download-directory/download-directory.github.io

@emtuls emtuls requested a review from Ana06 August 28, 2024 04:25
@Ana06
Copy link
Member

Ana06 commented Aug 28, 2024

We can download https://github.com/mandiant/flare-vm/archive/refs/heads/main.zip and extract the Images/VM folder in a small function. Although I am not sure if we can unzip the zip, as the tools (including the zip.vm package) are not installed yet.

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emtuls! 👍

@Ana06 Ana06 merged commit 3804904 into main Aug 28, 2024
1 check passed
@emtuls emtuls deleted the internet-detector branch August 28, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants