Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QS: Fuzzy search strings #964

Closed
wants to merge 2 commits into from
Closed

Conversation

ooprathamm
Copy link
Contributor

Closes #705

  • Experimented with Levenshtein distance and jaro similarity.
  • Tokenizing Levenshtein distance for sentence-like strings yielded the best results
  • For Levenshtein distance calculations, the RapidFuzz module was utilized. If a custom function for TaggedStrings is preferred, please let me know :)

@williballenthin
Copy link
Collaborator

hey @ooprathamm!

Sorry that you're missing a bit of context here: the QS issues tagged "ui" are ideas for an interactive TUI program (that doesn't exist yet). We had in mind to extend QS to have a bunch of additional functionality for exploring strings, like searching, inspecting, cross referencing, etc. using a console interface similar to ranger, gitui, htop, etc. But, we haven't finalized the design or built it yet, so these issues track our ideas.

Anyways, thank you for the PR here - I think we'll be able to use the implementation if/when we add searching to the TUI.

@ooprathamm
Copy link
Contributor Author

Apologies it seems I have misunderstood the context of the issue.
Thank you for bringing it to my attention.

@ooprathamm ooprathamm closed this Mar 11, 2024
@ooprathamm ooprathamm deleted the fuzzy branch March 11, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants