Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve debug message #907

Merged
merged 1 commit into from
Nov 14, 2023
Merged

improve debug message #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions floss/language/identify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,14 @@ def identify_language_and_version(sample: Path, static_strings: Iterable[StaticS
logger.info("Rust binary found with version: %s", version)
return Language.RUST, version

# Open the file as PE for further checks
# open file as PE for further checks
try:
pe = pefile.PE(str(sample))
except pefile.PEFormatError as err:
logger.debug(f"NOT a valid PE file: {err}")
logger.debug(
f"FLOSS currently only detects if Windows PE files were written in Go or .NET. "
f"This is not a valid PE file: {err}"
)
return Language.UNKNOWN, VERSION_UNKNOWN_OR_NA

is_go, version = get_if_go_and_version(pe)
Expand Down