Simplify language identification using dictionary mapping #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
while we're at it, we may want to derive the argparse choices from the Language enum. |
mr-tz
reviewed
Nov 10, 2023
floss/main.py
Outdated
Comment on lines
201
to
202
| choices=[lang.value for lang in Language], | ||
| default="none", |
There was a problem hiding this comment.
does this include the unknown language in the usage output and allow to use "none"?
There was a problem hiding this comment.
Yes, this change includes the unknown. I've updated it to allow "none" and not "Unknown" in latest commit 😄
mr-tz
reviewed
Nov 10, 2023
| else: | ||
|
|
||
| try: | ||
| lang_id = Language(args.language) |
There was a problem hiding this comment.
how can users disable language detection now?
|
now part of #901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests using a dictionary mapping approach for language identification.