Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pdbresym.vm #993

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Split pdbresym.vm #993

merged 1 commit into from
Apr 16, 2024

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Apr 16, 2024

Split pdbresym.vm into pdbresym.vm and dbs.pdbresym.vm to separate the download of the symbols (which increases the VM size considerable) and the too installation. @mandiant/flare-vm I think we should add pdbresym.vm to the default config, anything against it?

Closes #991

Split pdbresym.vm into pdbresym.vm and dbs.pdbresym.vm to separate the
download of the symbols (which increases the VM size considerable) and
the too installation.
@Ana06 Ana06 added 💎 enhancement It is working, but it could be better 🆕 package New package request/idea/PR 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Apr 16, 2024
@Ana06 Ana06 requested a review from emtuls April 16, 2024 13:03
@Ana06 Ana06 self-assigned this Apr 16, 2024
Copy link
Member

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works well and good to go! Thank you for doing that, it's much better this way. :)

@Ana06 Ana06 merged commit 38142cb into mandiant:main Apr 16, 2024
4 checks passed
@Ana06 Ana06 modified the milestone: FLARE-VM 2024 Q2 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better 🆕 package New package request/idea/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split pdbresym.vm in pdbresym.vm and pdbs.pdbresym.vm
2 participants