Update common.vm for all affected packages #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emtuls
added
🐛 bug
emtuls
force-pushed
the
fix-merge-git-and-zip
branch
2 times, most recently
from
eb68674 to
e2f9cd1
Compare
Ana06
reviewed
Apr 11, 2024
emtuls
force-pushed
the
fix-merge-git-and-zip
branch
from
e2f9cd1 to
084b4d4
Compare
|
That would be correct. Too many ctrl-z's 😬 Thanks for catching that! |
emtuls
force-pushed
the
fix-merge-git-and-zip
branch
2 times, most recently
from
c855eeb to
61fda2b
Compare
Ana06
reviewed
Apr 11, 2024
emtuls
force-pushed
the
fix-merge-git-and-zip
branch
5 times, most recently
from
303be5f to
fd4e741
Compare
emtuls
force-pushed
the
fix-merge-git-and-zip
branch
from
fd4e741 to
8b4738d
Compare
emtuls
changed the title
emtuls
changed the title
Ana06
approved these changes
Apr 12, 2024
| @@ -397,7 +399,7 @@ function VM-Install-From-Zip { | |||
| VM-Install-Shortcut -toolName $toolName -category $category -executablePath $executablePath -consoleApp $consoleApp -arguments $arguments | |||
| Install-BinFile -Name $toolName -Path $executablePath | |||
| } | |||
| return $executablePath | |||
| return ,@($toolDir, $executablePath) | |||
There was a problem hiding this comment.
Strange syntax with this comma. Maybe we should add a comment to clarify what this does, but this shouldn't block the PR as the packages are broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #959, there was an issue with packages not requiring the most up to date
common.vmleading to many packages to fail in thedaily.ymlcheck.There was also an issue with some older packages not performing
sha256 checksdue to it not being a mandatory requirement when made, which will need to be fully addressed later.This should fix these issues.