[installer] Fix creation of Admin Command Prompt #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix argument in the creation of the Admin Command Prompt shortcut (added to the FLARE-VM taskbar) that fails the installation of `installer.vm`.
emtuls
approved these changes
Mar 4, 2024
Ana06
commented
Mar 4, 2024
| @@ -2,7 +2,7 @@ | |||
| <package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd"> | |||
| <metadata> | |||
| <id>installer.vm</id> | |||
| <version>0.0.0.20240304</version> | |||
| <version>0.0.0.20240305</version> | |||
There was a problem hiding this comment.
so can i just use the installer.ps1 script again on the read me page? or do i have to do something special now?
There was a problem hiding this comment.
you can just use the installer.ps1 in the flare-vm repo. It will take the latest package from myget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix argument in the creation of the Admin Command Prompt shortcut (added to the FLARE-VM taskbar) that fails the installation of
installer.vm. The bug was introduced in #818, but it was not used until the version was fixed 5 days ago in #925.I tried to fix this issue in #931 🙈 I should have tested that properly. Sorry for that. I have tested this change locally (by using our
test_install.ps1script removing theinstaller.vmexception).Fixes mandiant/flare-vm#573