Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the lighthouse IDA Pro plugin #911

Closed
wants to merge 1 commit into from
Closed

Conversation

d35ha
Copy link
Member

@d35ha d35ha commented Feb 20, 2024

Required by #719.
Only works with IDA Pro and it requires DynamoRIO or Intel PIN.

@d35ha d35ha force-pushed the ida-plugins branch 2 times, most recently from 9308663 to 39bcf91 Compare February 20, 2024 18:58
@d35ha d35ha self-assigned this Feb 20, 2024
@d35ha d35ha added 🆕 package New package request/idea/PR 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Feb 20, 2024
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d35ha thanks for the PR!

@d35ha

it requires DynamoRIO or Intel PIN.

Then they should be installed by this package (likely as a dependency)

As mentioned in #913 (review), we can only merge PRs in which the linter and test succeed. We need to exclude packages without categories (no shortcut is created in the Tools directory) in the linter. Now we have ida.plugin.capa.vm in the EXCLUSIONS array. I suggest we change it by ida.plugin, which will exclude all IDA plugins.

# Remove the temp installation folder
Remove-Item $toolDir -Recurse

# Install the code coverage binaries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add to the comment why they are needed

$packageArgs =
@{
packageName = ${Env:ChocolateyPackageName}
unzipLocation = $toolDir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use $pluginsDir directly as unzip location instead of downloading to %TEMP% and copying items over

$zipUrl = "https://github.com/gaasedelen/lighthouse/releases/download/v$toolVersion/CodeCoverage-v$toolVersion-98830.zip"
$zipSha256 = "5b3e9659e934f8d7f4751cc0e20aa76de28822bc4f28b4936aa9be9c9e108595"

$toolDir = Join-Path ${Env:RAW_TOOLS_DIR} $toolName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this in %RAW_TOOLS_DIR%?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 🆕 package New package request/idea/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants