-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up categories for better organization #903
Conversation
79eb069
to
ecebee4
Compare
Errors seem to be package issues rather than issues with this commit specifically. Resource Hacker Failing (https://github.com/mandiant/VM-Packages/actions/runs/7945681229/job/21692630840?pr=903#step:4:1410):
Visual Studio failing (https://github.com/mandiant/VM-Packages/actions/runs/7945681229/job/21692630840?pr=903#step:4:2196):
|
ecebee4
to
08ba096
Compare
Resource Hacker has been broken for some time, see #741 |
@mandiant/commando-vm, @mandiant/flare-vm, @naacbin, @HuskyHacks, @KJaeYoung, @stevemk14ebr what do you think of the new categories proposals? Do we agree on this change? |
I re-trigger the build to see if the Visual Studio issue persisted (as it hadn't been detected by our test suite). Now we are getting hit by this chocolatey bug: https://status.chocolatey.org/issues/2024-02-19-chocolatey-community-repository-performance-degradation/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Office vs. Documents could be discussed
I agree with @mr-tz, I prefer Documents instead of Office. |
CI is working again. Only Resource Hacker is broken now (see discussion in #741). Note we can not merge this PR with a broken package (as all the packages won't be pushed to myget). So we need to either fix Resource Hacker first or move the change to Resource Hacker outside of this PR. |
LGTM. ArsenalImageMounter can stay in Utilities I think. |
I agree with a I'll also remove I can put Arsenal Image Mounter back into |
@naacbin
I'm indifferent on which category As far as ones that fall into
|
Indeed, it's more a forensic tool, keep it in |
4ccb041
to
3ab83af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mandiant/vms @naacbin @HuskyHacks, @KJaeYoung, @stevemk14ebr any concerns with these changes?
@mandiant/vms @naacbin @HuskyHacks, @KJaeYoung, @stevemk14ebr if no concerns are raised in the next 24 hours, we will merge this PR as it would cause conflicts with most package updates. |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3ab83af
to
9626267
Compare
9626267
to
d3325f7
Compare
d3325f7
to
46dcfff
Compare
Clean up categories for better organization
This mostly addresses things in #883, but not everything, as I did not remove any of the CommandVM categories as of yet.
This does fix the following issues:
#880
#881
#882
#884
#885
I moved
Burp Suite
toWeb Applications
, so that is now being used.I removed
Text Editors
in place ofProductivity Tools
andPython
didn't really exist anymore, but it was still an option somewhere, so I removed that as well.I changed the name for
VB
to beVisual Basic
just for a little bit more clarity.I added the following categories:
Memory
,Shellcode
,File Information
,Productivity Tools
,Registry
Also a few other fixes/reorganizations.