Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing hashcat intel check #892

Closed
wants to merge 2 commits into from
Closed

Conversation

Menn1s
Copy link
Contributor

@Menn1s Menn1s commented Feb 2, 2024

Removed the compatibility check; this can be handled by the installation process and the profiles used. Fixes #742 and #653. Also comes up in #877.

Hashcat should support a variety of systems and the check was not complex enough to accurately determine compatibility.

It does not seem trivial to get OpenCL on an ARM Windows system, however, I think this can be up to the user or a future fix to meet the compatibility.

Copy link

google-cla bot commented Feb 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

rethinksec added a commit to rethinksec/VM-Packages that referenced this pull request Feb 3, 2024
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the intel check @Menn1s! can you update the package version? 😄 Also, it seems you have commits here that don't belong to this PR. Let me know if you need help while rebasing, I may be able to help. 😉

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Menn1s you have forgotten to remove the $processor variable and the bot is not happy. Would it be ok for you if we merge #877 that includes this change (and where the test pass already(?

@Ana06
Copy link
Member

Ana06 commented Feb 14, 2024

@Menn1s approved that we merge #877 instead of this PR (documenting discussion outside GH)

@Ana06 Ana06 closed this Feb 14, 2024
Ana06 pushed a commit that referenced this pull request Feb 14, 2024
* Fix the 7z command as 7zip is not a valid command
* Remove hashcat intel check as per #892
@Ana06 Ana06 mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hashcat Failure Due to Processor Check
2 participants