-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing hashcat intel check #892
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the intel check @Menn1s! can you update the package version? 😄 Also, it seems you have commits here that don't belong to this PR. Let me know if you need help while rebasing, I may be able to help. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Fix the 7z command as 7zip is not a valid command * Remove hashcat intel check as per #892
Removed the compatibility check; this can be handled by the installation process and the profiles used. Fixes #742 and #653. Also comes up in #877.
Hashcat should support a variety of systems and the check was not complex enough to accurately determine compatibility.
It does not seem trivial to get OpenCL on an ARM Windows system, however, I think this can be up to the user or a future fix to meet the compatibility.