Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update x64dbg and plugins to latest #857

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Update x64dbg and plugins to latest #857

merged 3 commits into from
Feb 9, 2024

Conversation

stevemk14ebr
Copy link
Contributor

Resolves #853

@google-cla Google CLA
Copy link

google-cla bot commented Jan 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mr-tz
mr-tz reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but I haven't tested this locally

packages/x64dbg.vm/x64dbg.vm.nuspec Outdated Show resolved Hide resolved
mr-tz
mr-tz approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/x64dbgpy.vm/x64dbgpy.vm.nuspec Show resolved Hide resolved
Ana06
Ana06 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @stevemk14ebr thanks so much for bringing x64dbg to the latest version! 💘 and sorry for the delay 😓

@Ana06 Ana06 merged commit 9deb3be into mandiant:main Feb 9, 2024
4 checks passed
@Ana06
Copy link
Member

Ana06 commented Feb 9, 2024

For next time: please squash the commit in order to keep a clean commit history without fixup or update version again commits (or we should use squash and merge). I have just noticed, I should have merged it with squash and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz approved these changes

@Ana06 Ana06 Ana06 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package proposal: x64dbg.vm
3 participants
@stevemk14ebr @Ana06 @mr-tz