Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idafree to use VM-Install-Shortcut #850

Merged
merged 1 commit into from
Jan 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/idafree.vm/idafree.vm.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd">
<metadata>
<id>idafree.vm</id>
<version>8.3.0.20231129</version>
<version>8.3.0.20240119</version>
<authors>hex-rays</authors>
<description>Free version of IDA, a powerful Interactive DisAssembler and debugger</description>
<dependencies>
<dependency id="common.vm" version="0.0.0.20230925" />
<dependency id="common.vm" version="0.0.0.20240119" />
</dependencies>
</metadata>
</package>
4 changes: 1 addition & 3 deletions packages/idafree.vm/tools/chocolateyinstall.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Import-Module vm.common -Force -DisableNameChecking
try {
$toolName = 'idafree'
$category = 'Disassemblers'
$shortcutDir = Join-Path ${Env:TOOL_LIST_DIR} $category

$packageArgs = @{
packageName = ${Env:ChocolateyPackageName}
Expand Down Expand Up @@ -38,10 +37,9 @@ try {

VM-Assert-Path $launcherPath

$launcherShortcut = Join-Path $shortcutDir "ida.lnk"
$menuIcon = Join-Path $toolDir "ida.ico" -Resolve

Install-ChocolateyShortcut -shortcutFilePath $launcherShortcut -targetPath $launcherPath -IconLocation $menuIcon
VM-Install-Shortcut -toolName "ida" -category $category -executablePath $launcherPath -IconLocation $menuIcon

# ida64.exe supports both 32 bit and 64 bit in IDA >= 8.2
VM-Add-To-Right-Click-Menu $launcherName 'Open with IDA' "`"$launcherPath`" `"%1`"" "$menuIcon"
Expand Down
Loading