Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple executablePath from iconLocation #845

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Decouple executablePath from iconLocation #845

merged 1 commit into from
Jan 19, 2024

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Jan 19, 2024

This closes #842

@emtuls emtuls requested a review from Ana06 January 19, 2024 01:46
@emtuls emtuls self-assigned this Jan 19, 2024
Ana06
Ana06 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have a case where we want to use this new feature?

@emtuls emtuls merged commit 20f6c0f into main Jan 19, 2024
6 checks passed
@emtuls emtuls deleted the add-iconlocation branch January 19, 2024 15:54
@emtuls
Copy link
Member Author

emtuls commented Jan 19, 2024 •
edited
Loading

Hmmm. I would have used it for cyberchef.vm but with the modification I had to make, it doesn't fit the criteria for this anymore.

It looks like idafree.vm could be a suitable candidate though! I opened up an issue to have the change made: #848

I should be able to get to it soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ana06 Ana06 Ana06 approved these changes

Assignees

@emtuls emtuls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decouple "executablePath" from "IconLocation" inside "VM-Install-Shortcut"
2 participants
@emtuls @Ana06