Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VM-Install-Shortcut RunAsAdmin argument #840

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix VM-Install-Shortcut RunAsAdmin argument #840

merged 1 commit into from
Jan 18, 2024

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Jan 17, 2024

This fixes #839

@emtuls emtuls requested a review from Ana06 January 17, 2024 03:23
@emtuls emtuls self-assigned this Jan 17, 2024
@emtuls emtuls requested a review from mr-tz January 17, 2024 03:27
mr-tz
mr-tz approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Ana06
Ana06 requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @emtuls!

I think we should define an arguments variable and add the RunAsAdmin if it is true instead of duplicating the calls. 🤔

@emtuls emtuls force-pushed the common-vm-admin-fix branch 2 times, most recently from 28a9de5 to 9f5494d Compare January 17, 2024 17:56
@emtuls emtuls requested a review from Ana06 January 17, 2024 17:59
emtuls
emtuls commented Jan 17, 2024
View reviewed changes
Copy link
Member Author

@emtuls emtuls left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Made the change. 👍

@emtuls emtuls mentioned this pull request Jan 17, 2024
Closed
@emtuls emtuls force-pushed the common-vm-admin-fix branch from 9f5494d to 934cf87 Compare January 17, 2024 22:00
@emtuls emtuls requested a review from Ana06 January 17, 2024 22:20
@emtuls emtuls force-pushed the common-vm-admin-fix branch from 934cf87 to 1ff4fac Compare January 17, 2024 22:58
@emtuls emtuls force-pushed the common-vm-admin-fix branch from 1ff4fac to 0a4c841 Compare January 18, 2024 17:01
@emtuls emtuls requested a review from Ana06 January 18, 2024 17:26
@emtuls emtuls merged commit e2972ae into main Jan 18, 2024
6 checks passed
@emtuls emtuls deleted the common-vm-admin-fix branch January 18, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz approved these changes

@Ana06 Ana06 Ana06 approved these changes

Assignees

@emtuls emtuls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VM-Install-Shortcut incorrectly uses 'RunAsAdmin' argument
3 participants
@emtuls @Ana06 @mr-tz