Add VM-Assert-Signature & use to to add Google Chrome #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`VM-Assert-Signature` will allows us to install packages checking their signatures instead of their hash. Useful for Microsoft tools like sysinternals that use URLs without version. Co-authored-by: Genwei Jiang <[email protected]>
Add Google Chrome using the new `VM-Assert-Signature` function. Co-authored-by: Genwei Jiang <[email protected]>
Ana06
force-pushed
the
signature-chrome
branch
from
2160bfa to
898e91f
Compare
binjo
approved these changes
Jan 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Google Chrome using the new
VM-Assert-Signaturefunction to check its signature instead of its hash during the installation. This PR doesn't not address the following issues which should be addressed in a different PR to make the review process easier:Partially addresses #469. We need to use
VM-Assert-Signaturefor sysinternals.vm` to fully address that issue.