Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 7zip-15-05.vm #803

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Improve 7zip-15-05.vm #803

merged 1 commit into from
Jan 10, 2024

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Dec 20, 2023

At the moment 7zip is on path, change it by 7z.

@vm-packages do we agree on removing 7zip from the Utilities folder? I tend to think we don't need a shortcut for this tool as it is not really an analysis tool and it is already added to the right menu. But it can be used for things like extracting NSIS scripts. So it can be considered an analysis tool as well.

Closes #756

- Add 7z instead of 7zip to path
- Do not add the tool to the Utilities folder
- Order linter exclusions alphabetically
@Ana06 Ana06 added the 💎 enhancement It is working, but it could be better label Dec 20, 2023
@Ana06 Ana06 requested review from mr-tz, emtuls and a team December 20, 2023 11:12
@Ana06 Ana06 self-assigned this Dec 20, 2023
Copy link
Member

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! I agree that it shouldn't be in Utilities. Adds a bit of extra clutter for something that isn't used enough in that sense, but there is -some- use.

As an alternative, we could possibly put them inside of the Raw Tools Dir if we think there's a potential that having access to the binary shortcuts might be useful?

@Ana06
Copy link
Member Author

Ana06 commented Dec 21, 2023

@emtuls

As an alternative, we could possibly put them inside of the Raw Tools Dir if we think there's a potential that having access to the binary shortcuts might be useful?

How do you purpose this shortcut to be used? I can't think of a reason to want to keep the shortcut in any location apart from finding it in the Tools directory (if we consider it to be an analysis tool, what I argue is not), but maybe I am missing something. 🤔

@emtuls
Copy link
Member

emtuls commented Dec 21, 2023

@emtuls

As an alternative, we could possibly put them inside of the Raw Tools Dir if we think there's a potential that having access to the binary shortcuts might be useful?

How do you purpose this shortcut to be used? I can't think of a reason to want to keep the shortcut in any location apart from finding it in the Tools directory (if we consider it to be an analysis tool, what I argue is not), but maybe I am missing something. 🤔

I don't think I can think of any reason I would, as I prefer the right click option, but I was airing on the side of caution that there may be users that prefer the method of dragging a file onto the shortcut to open it in 7z, or they might not have a right click (a bit rare though, especially with modern hot keys built into Windows).

Outside of that. I'm all for making the change to remove it if those use cases aren't ones we should consider. :)

@day1player
Copy link
Contributor

Agreed we dont need a shortcut for it

@Ana06 Ana06 merged commit f9b8229 into mandiant:main Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7zip improvements
3 participants