Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Package update #759

Merged
merged 5 commits into from
Dec 13, 2023
Merged

🤖 Package update #759

merged 5 commits into from
Dec 13, 2023

Conversation

vm-packages
Copy link
Contributor

Automated package update

@Ana06
Copy link
Member

Ana06 commented Nov 30, 2023

@mr-tz have you tested this update locally? I think we should test the automate updates to avoid issues when running the tool that may not be detected by our test suite like #760

@mr-tz
Copy link
Contributor

mr-tz commented Nov 30, 2023

I have not :( Do you suggest to do this for every package update?

@Ana06
Copy link
Member

Ana06 commented Nov 30, 2023 •
edited
Loading

I have not :( Do you suggest to do this for every package update?

Yes. If we start building the VM automatically, we will have broken tools otherwise. I think it would be better to merge these updates less regularly, but ensure they have been tested (at least that the tool runs). We could also explore testing running tools in the test suite. But I am not sure how well that would work 🤔

@mr-tz
Copy link
Contributor

mr-tz commented Dec 1, 2023

Yeah, ok 😑

@vm-packages vm-packages force-pushed the package-update branch 2 times, most recently from fa3882d to aa7355c Compare December 12, 2023 11:58
Ana06
Ana06 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just tested the update and it seems to work fine.

Closes #760

@Ana06 Ana06 merged commit 54b3ab9 into main Dec 13, 2023
6 checks passed
@Ana06 Ana06 mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz approved these changes

@Ana06 Ana06 Ana06 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vm-packages @Ana06 @mr-tz