Clean up psnotify chocoinstall #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emtuls
requested review from
vm-packages and
Ana06
and removed request for
vm-packages
Ana06
reviewed
Oct 23, 2023
There was a problem hiding this comment.
@emtuls please do not merge PRs without a review (specially if there are discussions going on) and do not approve your own changes. The idea is that someone else reviews the changes as merging automatically makes packages available in myget. This helps avoiding cleanup PRs like this one.
[nitpick] Use the imperative mood in the subject line of commit messages. See for example https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/
emtuls
changed the title
Ana06
requested changes
Oct 25, 2023
| Install-ChocolateyShortcut -shortcutFilePath $shortcut -targetPath $executablePath -WorkingDirectory $executableDir | ||
| VM-Assert-Path $shortcut | ||
|
|
||
| return $executablePath |
There was a problem hiding this comment.
This return should be removed. It was in the helper to use from the calling code (outside the helper). We can merge the PR after that.
Ana06
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.