Add the ImHex.vm package #700
Conversation
| Install-ChocolateyShortcut -shortcutFilePath $shortcut -targetPath $executablePath | ||
| VM-Assert-Path $shortcut | ||
|
|
||
| VM-Add-To-Right-Click-Menu $toolName $toolName "`"$executablePath`" `"%1`"" "$executablePath" |
There was a problem hiding this comment.
[discussion] If we add this tool to the default configuration, we will have two hex editors on the right menu, @mandiant/flare-vm do we want to add this tool to the default config? if so, are we ok with this?
There was a problem hiding this comment.
@d35ha the code looks great! can you please squash your commits into just one Add imhex.vm commit in order to maintain a clean commit history? I think this will also fix the CLA issue. I think this is caused by my personal email being co-author of one of the commits (asking around to see if there is a solution for this in general).
Please let me know if you need any help squashing your commits (it can be tricky if you are doing it for the first time). Some documentation that may help: https://www.freecodecamp.org/news/git-squash-commits
| @@ -157,7 +157,7 @@ function VM-Check-Reboot { | |||
| ) | |||
| try { | |||
| if (Test-PendingReboot){ | |||
| VM-Write-Log "ERROR" "Host must be rebooted before continuing install of $package.`n" | |||
| VM-Write-Log "ERROR" "Host must be rebooted before continuing installation of $package.`n" | |||
There was a problem hiding this comment.
Something weird happen while rebasing as I am the author of the commit and you the commiter (you should get authorship) and thisthis change is already in main. But I think merging shouldn't break anything
No description provided.