Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Add garbageman.vm #349

Merged
merged 1 commit into from
Oct 21, 2023
Merged

🤖 Add garbageman.vm #349

merged 1 commit into from
Oct 21, 2023

Conversation

vm-packages
Copy link
Contributor

Automated PR from #343 🚀

@vm-packages vm-packages added the 🆕 package New package request/idea/PR label May 24, 2023
@emtuls emtuls force-pushed the package-garbageman branch from ac2f070 to 42b9bf3 Compare May 26, 2023 00:21
@Ana06 Ana06 mentioned this pull request May 26, 2023
Ana06
Ana06 previously requested changes Jun 6, 2023
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly as with #368, we are missing dependencies here.

Screenshot 2023-06-06 at 10 50 05

@Ana06 Ana06 added this to the FLARE-VM 2023 Q3 milestone Jun 6, 2023
@emtuls emtuls force-pushed the package-garbageman branch from 42b9bf3 to da88f89 Compare August 2, 2023 21:49
@emtuls
Copy link
Member

emtuls commented Aug 25, 2023

There is an issue with GarbageMan in that it will display an error when opening the program via a shortcut, due to relative path usage of a file it depends on.

The tool works properly if you open it directly from its extracted position, which is not ideal, but could work for the meantime if we intend to merge this before a fix is made. Looking at ways to mitigate this on our end.

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is a ugly error and that we should figure out a solution before getting this merged. What about using the current directory the path of GarbageMan? We may not be able to use the helper function or we may need to modify the helper function to add this option.

Closes #343.

fixed installer
@emtuls emtuls force-pushed the package-garbageman branch from da88f89 to efd3869 Compare October 21, 2023 02:18
@emtuls emtuls merged commit 1edeac3 into main Oct 21, 2023
4 checks passed
@emtuls emtuls deleted the package-garbageman branch October 21, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 package New package request/idea/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants