Add LECmd by Eric Zimmerman #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thejoelpatrol sorry that we haven't reviewed this PR before.
You should require the dependency explicitly. Likely the dependency is either installed by default in your windows version or required by another package installed by flare-vm. The tool should be able to install correctly in other environments. See other .net packages, for example: |
Merged
|
@thejoelpatrol is it ok with you if we close this PR in favour of #778? |
|
No problem, go ahead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool parses Windows shortcut files (LNK), which can do all kinds of stuff besides simply point to local disk files.
This version requires .NET version 4, which is apparently already installed in FLARE VM. (there's also a version for .NET 6 which did not work for me in the VM). I'm not sure if there's a way to declare that dependency, or if we can just assume it's there.