Remove double console when opening fakenet #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emtuls
added
🐛 bug
Ana06
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Even if we run it as a console app (keeping the second console), the one with the fakenet output get closed when stopping fakenet. So I agree we shouldn't run it as a console app. I'll open an issue in fakenet asking to be able to keep the output after stopping fakenet with a future fakenet version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening Fakenet via the shortcut, it spawns a second command prompt which runs Fakenet.
The original intent was to have Fakenet opened in a cmd that would not close after terminating Fakenet, but unfortunately this doesn't seem to be something that can be done via execution through a shortcut, rather, I believe it needs to be done from within Fakenet.
This PR will put fakenet back to its original way where it opens a single command prompt, but will terminate the cmd after closing fakenet.