Fix Internet Detector Background/Taskbar Issues #1221
Conversation
emtuls
added
🐛 bug
| if not load_default_settings(): | ||
| # If not found, get the current settings and save them as defaults | ||
| default_color_prevalence = get_current_color_prevalence() | ||
| default_color = get_current_taskbar_color() |
There was a problem hiding this comment.
I think we should check before saving the color that it is not pink and use a default gray if it is. This way we ensure that there can never be an error, as these bug show how tricky implementing it correct is.
There was a problem hiding this comment.
In the end, with this implementation we are setting a default (the one the user had before the tool started running), as the user can't change the color anymore. So I wonder, if it would be simpler and more reliable to just default to black and pink.
If we keep it this way, we should document somewhere (not necessary in this PR, maybe in the wiki) how the user could change the color. In the long term we could move this tool to its own project with a readme.
This fixes both #1216 and #1217
The issue with the wallpaper (#1216) was actually that
internet_detectorended up in a broken state after theinstaller.vmperformed aVM-Refresh-Desktop, which madeinternet_detectorcontinue to run but unable to modify the background and also display an indicator in the taskbar. This has been fixed by having a detection for ifexplorer.exeis restarted and/or if the taskbar icon is removed, and if so, it attempts to restart itself or die gracefully so that the scheduled task can start it back up again properly.The Taskbar issue (#1217) has been resolved by storing the old/default taskbar color scheme into a registry key that will be checked if it exists before setting a new default. It then reads this value for when it adjusts back to the state of when it does not detect internet.
I have also adjusted the package to re-enable the scheduled task and also made the time to kick off every 1 minute instead of 2 minutes.