vm.common: add -iconLocation param to VM-Install-From-Zip #1202
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fariss
force-pushed
the
add-iconLocation-param
branch
3 times, most recently
from
777a5c4 to
3cc8135
Compare
Ana06
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Thank for sending a PR to add the iconLocation parameter to VM-Install-From-Zip! 💖
As documented in the wiki:
The version needs to be increased every time you modify an existing package
Otherwise the package can't be pushed to MyGet, GH actions push it when merging the PR. So you need to modify the version in packages/common.vm/common.vm.nuspec to be 0.0.0.20241212. This is also the reason the linter is not happy.
I recommend to also modify the capa-explorer-web.vm package in the same PR that you add the parameter (if you wish in a different commit) as then we can test that the new modification is working. 😉
fariss
force-pushed
the
add-iconLocation-param
branch
from
3cc8135 to
aaaa28b
Compare
fariss
force-pushed
the
add-iconLocation-param
branch
2 times, most recently
from
c927837 to
111a5b4
Compare
fariss
force-pushed
the
add-iconLocation-param
branch
3 times, most recently
from
53e44d3 to
aaa0cab
Compare
fariss
commented
Dec 18, 2024
Comment on lines
+10
to
+11
| $iconName = "favicon.ico" | ||
| VM-Install-From-Zip $toolName $category $zipUrl $zipSha256 -executableName $executableName -iconLocation $iconName -withoutBinFile -innerFolder $true |
There was a problem hiding this comment.
@Ana06 please let me know if this works out for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1187