Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new package capa-explorer-web.vm #1181

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

fariss
Copy link
Contributor

@fariss fariss commented Nov 28, 2024

closes #1136

This PR adds a new VM-package capa-explorer-web.vm.

ZIP URL: https://github.com/mandiant/capa/raw/refs/heads/master/web/explorer/releases/capa-explorer-web-v1.0.0-6a2330c.zip

@mr-tz
Copy link
Contributor

mr-tz commented Dec 2, 2024

Thanks, @mandiant/flare-vm can hopefully review and test this soon.

@Ana06 Ana06 requested a review from sara-rn December 3, 2024 10:45
@Ana06 Ana06 changed the title Add new pacakge capa-explorer-web.vm Add new package capa-explorer-web.vm Dec 9, 2024
@fariss fariss force-pushed the add-capa-explorer-web branch from c61fc92 to 0d561e8 Compare December 9, 2024 08:59
@fariss fariss requested a review from sara-rn December 9, 2024 09:01
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fariss thank you so much for providing a link for capa Explorer Web and for going even a step further and sending a PR to add the package! 🙏 The structure of VM-Packages is a bit tricky to learn and you have made an amazing job creating your first package! 😊

Thanks @sara-rn for reviewing the PR.

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fariss thanks for the implementing the proposed changes! Could you squash your commits in just one Add new package capa-explorer-web.vm? I prefer to avoid having fixup commits to keep a clean commit history. When you do this, could you either remove me as co-author or change the email to my [email protected] email? The Google CLA check does not like my personal email.

If you need help to squash/modify the commits, please let me know and I can provide more information about how to do it. 😉

packages/capa-explorer-web.vm/capa-explorer-web.vm.nuspec Outdated Show resolved Hide resolved
@Ana06
Copy link
Member

Ana06 commented Dec 10, 2024

@mandiant/flare-vm I think we should add this package to the default FLARE-VM config after we merge this PR 😉

@fariss fariss force-pushed the add-capa-explorer-web branch from 528cba2 to 4a416d8 Compare December 10, 2024 10:26
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works nicely, the code looks good too. Thanks @fariss for all the work!!! 🫶

@Ana06 Ana06 merged commit 2953d2e into mandiant:main Dec 10, 2024
4 checks passed
@fariss fariss deleted the add-capa-explorer-web branch December 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL package proposal: capa-explorer-web.vm
4 participants