-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new package capa-explorer-web.vm #1181
Conversation
Thanks, @mandiant/flare-vm can hopefully review and test this soon. |
c61fc92
to
0d561e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fariss thanks for the implementing the proposed changes! Could you squash your commits in just one Add new package capa-explorer-web.vm
? I prefer to avoid having fixup commits to keep a clean commit history. When you do this, could you either remove me as co-author or change the email to my [email protected]
email? The Google CLA check does not like my personal email.
If you need help to squash/modify the commits, please let me know and I can provide more information about how to do it. 😉
@mandiant/flare-vm I think we should add this package to the default FLARE-VM config after we merge this PR 😉 |
528cba2
to
4a416d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works nicely, the code looks good too. Thanks @fariss for all the work!!! 🫶
closes #1136
This PR adds a new VM-package capa-explorer-web.vm.
ZIP URL:
https://github.com/mandiant/capa/raw/refs/heads/master/web/explorer/releases/capa-explorer-web-v1.0.0-6a2330c.zip