Set Chrome as default browser

[emtuls]

This fixes #822

It also fixes an issue in the function VM-Update-Registry-Value in common.vm where a parameter was not being used and other parameter names were not used correctly.

[Ana06]

this change breaks the call to this function in VM-Apply-Configurations used to parse our config:
VM-Update-Registry-Value -name $name -path $path -value $value -type $type -data $data. I think it may possible to remove name from this function as it is a description in the config, but we do use data and removing it, breaks the installer.

[emtuls]

Ah, I missed that one. I was looking at packages that used the function and didn't see it used, so I assumed it was just a mistake. :)

Just seems odd to me to use $value for -Name in Set-ItemProperty and not $name, and then use $data / $validatedData for -Value instead of using $value.

I would think that changing the naming convention to what Set-ItemProperty expects (to mean, also updating the places that use this function) might be a better route to take, but we can address that in another PR. :)

[Ana06]

@emtuls I think this PR is not failing in the CI because of the exit code as you told me, but because you are using VM-Update-Registry-Value:

cmdlet VM-Update-Registry-Value at command pipeline position 1
data
  Confirmation (`-y`) is set.
  Respond within 30 seconds or the default selection will be chosen.
ERROR: Cannot process command because of one or more missing mandatory parameters: data.

Please change it by Set-ItemProperty as I suggested in my previous comment.

[emtuls]

Ah, I thought I made that change... I overlooked that. Thank you!

[Ana06]

Waiting for a fix for #1188 to be able to test this PR. 😇

[Ana06]

#1188 has been fixed so I have now been able to test this locally. It works perfectly! ✨ I have already rebased as there was a merge conflict in the nuspec because of #1169. This PR can be now merged! 😉