Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily test #1122

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix daily test #1122

merged 2 commits into from
Aug 26, 2024

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Aug 26, 2024

The daily test hasn't run correctly in the last weeks. The testing of the packages seem to be aborted because the default maximum execution time (6 hours) is exceeded. Increase the timeout to 12 hours.

The failure caused the README badge to be updated wrongly:
image
Change the conclusion status of the package testing step to success even if packages fail, as the action is still
running as expected (we want to count the failures, so we expect failures). This way we detect other errors early avoiding the wiki and the badge to be updated.

Ana06 added 2 commits August 26, 2024 12:56
The daily test hasn't run correctly in the last weeks. The testing of
the packages seem to be aborted because the default maximum execution
time (6 hours) is exceeded. Increase the timeout to 12 hours.
Failures (such as a timeout error while testing the packages) are
causing the README badge to be updated wrongly. Change the conclusion status of the
package testing step to success even if packages fail, as the action is still
running as expected (we want to count the failures, so we expect
failures). This way we detect other errors early avoiding the wiki and
the badge to be updated.
@Ana06 Ana06 added 🐛 bug Something isn't working 🏃 CI Related to CI labels Aug 26, 2024
@Ana06 Ana06 requested a review from vm-packages August 26, 2024 10:58
@Ana06 Ana06 self-assigned this Aug 26, 2024
@Ana06 Ana06 merged commit c2e1958 into mandiant:main Aug 26, 2024
4 checks passed
@Ana06
Copy link
Member Author

Ana06 commented Aug 26, 2024

Thanks for the review @mr-tz! I have just triggered the daily test manually 😉

@emtuls
Copy link
Member

emtuls commented Aug 27, 2024

Seems we are getting an ERROR still after the latest run (interesting that the timeout max is still 360 mins, it might be capped at that...):
image

It looks like there's an issue with git.install dependency, where git isn't installing correctly, which then leads to a bunch of other installation failures: https://github.com/mandiant/VM-Packages/actions/runs/10559091787/job/29249826630#step:3:4884
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🏃 CI Related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants