Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .py default app execution #1114

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Update .py default app execution #1114

merged 1 commit into from
Aug 29, 2024

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Jul 27, 2024

This fixes the issue with python files prompting for a default execution app noted here: #1085

@emtuls emtuls added 🐛 bug Something isn't working 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Jul 27, 2024
@emtuls emtuls self-assigned this Jul 27, 2024
@emtuls emtuls requested a review from Ana06 July 27, 2024 01:16
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emtuls have you tried executing a python tool after this change? Python tools do not work as expected.

Packages in this PR

Installing the packages in this PR + libraries.python3.vm in a minimal FLARE-VM installtion, running C:\Tools\DidierStevensSuite-8190354314d6f42c9ddc477a795029dc446176c5\strings.py -m produces no output:
image

Packages from feed

After running choco install libraries.python3.vm didier-stevens-suite.vm didier-stevens-beta.vm, running C:\Tools\DidierStevensSuite-8190354314d6f42c9ddc477a795029dc446176c5\strings.py -m runs normally:
image

Interesting is also that it didn't ask me which tool I wanted to use to open the Python file. I wonder if the installation of another tool breaks this... 🤔

@emtuls
Copy link
Member Author

emtuls commented Aug 25, 2024

@Ana06 I believe this is because of common.vm versioning. I attempted to install the packages on a more fresh FLARE-VM and it defaulted to installing a newer version of common.vm (meaning, it didn't install the required fix that this PR introduced).

If you either force install the version from this PR (0.0.0.20240726), or change the versioning of common.vm in this PR to a newer one than the one that gets installed (this was 0.0.0.20240821 for me) before installing common.vm, then it should work (also be sure that you install python3.vm after you install the correct common.vm so that the registry fix is performed).

But no worries, I will update this package with a newer version for common.vm for you to retest. :)

@Ana06
Copy link
Member

Ana06 commented Aug 26, 2024

@emtuls I see, there was a newer common version in MyGet which means I was not testing this changes. Can you rebase to solve the merge conflicts please? I'll test it after that 😉

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! 🚀 Thanks @emtuls! 🎉

@Ana06 Ana06 merged commit 986ab9e into main Aug 29, 2024
6 checks passed
@emtuls emtuls deleted the python-fix branch September 16, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌀 FLARE-VM A package or feature to be used by FLARE-VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants