Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libraries.python3.vm] Add pycryptodomex library #1113

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Jul 26, 2024

Add pycryptodomex Python library, the new PyCryptodome. The old PyCrypto and PyCryptodome can coexist, keep the old one for better compatibility.

@Ana06 Ana06 added 💎 enhancement It is working, but it could be better 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Jul 26, 2024
@Ana06 Ana06 requested a review from a team July 26, 2024 14:48
@Ana06 Ana06 self-assigned this Jul 26, 2024
Add `pycryptodomex` Python library, the new PyCryptodome. The old
PyCrypto and PyCryptodome can coexist, keep the old one for better
compatibility.
Copy link
Member

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I was slightly confused at first with how the repo read in regards to which libraries can coexist, but this seems to be the correct way. :)

Thanks for the addition!

@Ana06 Ana06 merged commit b0d46c4 into mandiant:main Aug 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants