Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the package name against its folder and nuspec file #1089

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

d35ha
Copy link
Member

@d35ha d35ha commented Jun 11, 2024

Closes #1071.

@d35ha d35ha self-assigned this Jun 11, 2024
@d35ha d35ha requested a review from emtuls June 11, 2024 10:09
@d35ha d35ha added this to the FLARE-VM 2024 Q2 milestone Jun 11, 2024
@d35ha d35ha added the 💎 enhancement It is working, but it could be better label Jun 11, 2024
Copy link
Member

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, but outside of that, it looks good! Thank you @d35ha!

scripts/test/lint.py Outdated Show resolved Hide resolved
@d35ha d35ha force-pushed the linter-check-package-name branch from aeff6b0 to 6351a0f Compare June 12, 2024 05:00
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @d35ha! Just a minor improvement idea.

scripts/test/lint.py Outdated Show resolved Hide resolved
@d35ha d35ha force-pushed the linter-check-package-name branch from 3f57918 to 3629f6a Compare June 13, 2024 07:02
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Ana06 Ana06 requested a review from emtuls June 13, 2024 11:00
@emtuls emtuls merged commit 17ed8ee into mandiant:main Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter idea: check file/folder name matches the package name in nuspec
3 participants