Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python and jupyter vscode extension packages #1087

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

d35ha
Copy link
Member

@d35ha d35ha commented Jun 11, 2024

Closes #1074.

@d35ha d35ha force-pushed the vscode-extensions branch from 8d66af9 to aca19f0 Compare June 11, 2024 08:38
@d35ha d35ha requested a review from emtuls June 11, 2024 08:38
@d35ha d35ha self-assigned this Jun 11, 2024
@d35ha d35ha added 🆕 package New package request/idea/PR 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Jun 11, 2024
Copy link
Member

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add all of these extensions separately. Just adding the python extension alone adds both Pylance and Python Debugger (https://marketplace.visualstudio.com/items?itemName=ms-python.python). :)

Also, I think we should name the packages vscode.python.vm and vscode.jupyter.vm instead, as the extension piece makes the name a bit longer than necessary.

Overall, they work great though! Just those changes and I think it'll be good to go.

@d35ha
Copy link
Member Author

d35ha commented Jun 12, 2024

Also, I think we should name the packages vscode.python.vm and vscode.jupyter.vm instead, as the extension piece makes the name a bit longer than necessary.

@emtuls
Renaming it to vscode.<ext>.vm would make it harder to exclude these extensions at lint.py

"vscode.extension.",

also I think it's consistent with notepadpp.plugin.<plugin>.vm and ida.plugin.<plugin>.vm.

@d35ha d35ha force-pushed the vscode-extensions branch from aca19f0 to 50accc0 Compare June 12, 2024 05:17
@d35ha
Copy link
Member Author

d35ha commented Jun 12, 2024

@emtuls
Updated.

@d35ha d35ha force-pushed the vscode-extensions branch from 50accc0 to 0ced798 Compare June 12, 2024 05:26
@d35ha d35ha changed the title Add debugpy, jupyter and pylance vscode extension packages Add python and jupyter vscode extension packages Jun 12, 2024
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @d35ha and for the review @emtuls, LGTM!

@Ana06 Ana06 requested a review from emtuls June 12, 2024 08:36
Copy link
Member

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Awesome job @d35ha, thank you!

@emtuls emtuls merged commit 19a360b into mandiant:main Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 🆕 package New package request/idea/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code Python Extension
3 participants