-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python and jupyter vscode extension packages #1087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to add all of these extensions separately. Just adding the python
extension alone adds both Pylance
and Python Debugger
(https://marketplace.visualstudio.com/items?itemName=ms-python.python). :)
Also, I think we should name the packages vscode.python.vm
and vscode.jupyter.vm
instead, as the extension piece makes the name a bit longer than necessary.
Overall, they work great though! Just those changes and I think it'll be good to go.
@emtuls VM-Packages/scripts/test/lint.py Line 322 in aca19f0
also I think it's consistent with |
@emtuls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Awesome job @d35ha, thank you!
Closes #1074.