Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added static download link for NetworkMiner 2.9 #1059

Closed
wants to merge 0 commits into from

Conversation

erik4711
Copy link
Contributor

No description provided.

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A URL with the version, this is great! The version update in the nuspec is missing. We need to increase the version to be able to push the changes to MyGet (see documentation)

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see changes, but the version is still not updated in the nuspec. @erik4711 please let me now if you need any help. 😉

@erik4711
Copy link
Contributor Author

It feels a bit awkward to set the NetworkMiner version to something other than 2.9.0 in networkminer.vm.nuspec. Is it possible to set the nuspec version to something like 2.9.0-static or similar to indicate that the version is the same, but the source URL has changed?

@Ana06
Copy link
Member

Ana06 commented Jun 21, 2024

We use the forth segment when changing a package but keeping the same tools version, as documented in the wiki. In this case: 2.9.0.20240621.

@emtuls
Copy link
Member

emtuls commented Jul 26, 2024

Hi @erik4711!

Wanted to follow up to see if you would be able to make the change in the .nuspec from <version>2.9.0</version> to <version>2.9.0.20240621</version> and we can look into merging the change? 😊

Thank you!

@erik4711
Copy link
Contributor Author

erik4711 commented Aug 9, 2024

@emtuls @Ana06 See pull request #1115 with updated URL and nuspec version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants