Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package to fix daily failure #1023

Merged
merged 1 commit into from
May 16, 2024
Merged

Update package to fix daily failure #1023

merged 1 commit into from
May 16, 2024

Conversation

naacbin
Copy link
Collaborator

@naacbin naacbin commented May 7, 2024

  • dcode.vm
  • dotnet-6.vm
  • recmd.vm
  • rla.vm
  • timeline_explorer.vm

@naacbin
Copy link
Collaborator Author

naacbin commented May 7, 2024

Dokan is in failure (which cause memprocfs too) but I haven't got the time to investigate the error

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the packages @naacbin! 💘

<authors>Microsoft</authors>
<description>Metapackage for .NET6 to ensure all packages use the same version.</description>
<dependencies>
<dependency id="common.vm" />
<dependency id="dotnet-6.0-desktopruntime" version="(6.0.14, 6.0.26]" />
<dependency id="dotnet-6.0-runtime" version="(6.0.14, 6.0.26]" />
<dependency id="dotnet-6.0-desktopruntime" version="[6.0.14, 6.1)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to increase the .NET version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed but the syntax was incorrect "(]" instead of "[)" and increasing minor version won't be a problem.

@Ana06 Ana06 requested a review from a team May 7, 2024 13:05
@Ana06 Ana06 merged commit 3808864 into main May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants