Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force same icon layout when sorting #1009

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Force same icon layout when sorting #1009

merged 1 commit into from
Apr 25, 2024

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Apr 24, 2024

This fixes #974

I also moved the icon sorting function call outside of the VM-Remove-DesktopFiles call since it felt a little out of place as it's not removing desktop files, rather, it's sorting icons on the desktop, and it also made it more clear what individual steps were being performed when calling VM-Clean-Up

@emtuls emtuls self-assigned this Apr 24, 2024
@emtuls emtuls force-pushed the sort-desktop-icons branch 2 times, most recently from 28d3612 to 4745435 Compare April 24, 2024 05:21
@emtuls emtuls requested a review from Ana06 April 24, 2024 05:28
@emtuls emtuls added 💎 enhancement It is working, but it could be better 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Apr 24, 2024
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing some extra research on this @emtuls!

packages/common.vm/tools/vm.common/vm.common.psm1 Outdated Show resolved Hide resolved
@emtuls emtuls force-pushed the sort-desktop-icons branch from 4745435 to 4d08b6b Compare April 24, 2024 16:10
@emtuls emtuls requested a review from Ana06 April 24, 2024 16:55
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work consistently, thanks a lot @emtuls!

@Ana06 Ana06 merged commit 31be52c into main Apr 25, 2024
6 checks passed
@emtuls emtuls deleted the sort-desktop-icons branch April 25, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VM-Clean-Up - fix sort Desktop icons
2 participants