Add helper function for Node tools #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a `VM-Install-Node-Tool-From-Zip` helper function to install Node tools installed with `npm` and normally downloaded from a GitHub repository as a ZIP with an inner folder.
I do not understand why this linter has started complaining now, as we
use positional parameters in many functions:
```
packages\common.vm\tools\vm.common\vm.common.psm1
1 rule violation found. Severity distribution: Error = 0, Warning = 0, Information = 1
RuleName Severity ScriptName Line Message
-------- -------- ---------- ---- -------
PSAvoidUsingPositionalParameters Information vm.common. 393 Cmdlet 'VM-Install-From-Zip' has positional
psm1 parameter. Please use named parameters instead of
positional parameters when calling a command.
```
Exclude this violation as it is of `Information` severity and we would
need to make a lot of changes to fix it.
Ana06
added
💎 enhancement
Ana06
force-pushed
the
node-helper
branch
2 times, most recently
from
b47fce8 to
be358d4
Compare
emtuls
requested changes
Apr 22, 2024
There is a try-catch inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
VM-Install-Node-Tool-From-Ziphelper function to install Node tools installed withnpmand normally downloaded from a GitHub repository as a ZIP with an inner folder.First step to address #999
I do not understand why
PSAvoidUsingPositionalParametershas started complaining now in the linter, as we use positional parameters in many functions:Exclude this violation as it is of
Informationseverity and we wouldneed to make a lot of changes to fix it.