Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split pdbresym.vm in pdbresym.vm and pdbs.pdbresym.vm #991

Closed
Ana06 opened this issue Apr 12, 2024 · 2 comments · Fixed by #993
Closed

Split pdbresym.vm in pdbresym.vm and pdbs.pdbresym.vm #991

Ana06 opened this issue Apr 12, 2024 · 2 comments · Fixed by #993
Assignees
@Ana06
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed 🆕 package New package request/idea/PR
Milestone
FLARE-VM 2024 Q2

Comments

@Ana06
Copy link
Member

Ana06 commented Apr 12, 2024

Details

As per @stevemk14ebr feedback in #986 (comment), I think we should split the downloading of the symbol in a separate package, something like pdbresym.vm (just the tool) and pdbs.pdbresym.vm (which requires the tool and download the symbols).

@mandiant/flare-vm opinions on the naming? Should we add the new pdbresym.vm to the default flare-vm config?
@Ana06 Ana06 added 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed 🆕 package New package request/idea/PR 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Apr 12, 2024
@Ana06 Ana06 self-assigned this Apr 12, 2024
@emtuls emtuls mentioned this issue Apr 12, 2024
Closed
@stevemk14ebr
Copy link
Contributor

I like this idea, and I agree with Elliot this is the best way for now (per linked issue)

@Ana06 Ana06 mentioned this issue Apr 16, 2024
Merged
@stevemk14ebr
Copy link
Contributor

Thanks Ana!

@Ana06 Ana06 added this to the FLARE-VM 2024 Q2 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ana06 Ana06

Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed 🆕 package New package request/idea/PR
Projects
None yet
Milestone
FLARE-VM 2024 Q2
Development

Successfully merging a pull request may close this issue.

Split pdbresym.vm Ana06/VM-Packages
2 participants
@stevemk14ebr @Ana06