Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM-Clean-Up - fix sort Desktop icons #974

Closed
Ana06 opened this issue Apr 3, 2024 · 1 comment · Fixed by #1009
Closed

VM-Clean-Up - fix sort Desktop icons #974

Ana06 opened this issue Apr 3, 2024 · 1 comment · Fixed by #1009
Assignees
Labels
🐛 bug Something isn't working

Comments

@Ana06
Copy link
Member

Ana06 commented Apr 3, 2024

Details

I have encountered two issues with VM-Clean-Up:

  • When sorting the Desktop icons by type, if they are already sorted, they are sorted by type in reverse order. This causes the VM to look different depending how the icons were sorted and it is a problem to distribute builds that look the same.
  • When running VM-Clean-Up from a PowerShell tab in the Windows Terminal, the icons are not sorted. Does maybe increasing the time we wait fixes this? Do we need to document to run this from PowerShell and not from the Windows Terminal?

@emtuls ideas?

@Ana06 Ana06 added the 🐛 bug Something isn't working label Apr 3, 2024
@Ana06 Ana06 assigned Ana06 and emtuls Apr 3, 2024
@emtuls
Copy link
Member

emtuls commented Apr 24, 2024

After many hours of testing various things, I finally found a solution that works for both standard Powershell and Windows-Terminal Powershell. 😊

Regular Powershell is a little bit easier, since when we perform (New-Object -ComObject Shell.Application).toggleDesktop();, it automatically brings the focus to the desktop, whereas with Windows-Terminal, it doesn't.

The general sorting solution ended up just being to sort by Name first, then by Item Type. Testing various ways does seem to work how we would like.

The only maybe more ideal way would be to have Tools folder just under the Recycle Bin, but this was the best I could get.

@Ana06 Ana06 added this to the FLARE-VM 2024 Q2 - P1 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants