Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM-Install-Shortcut incorrectly uses 'RunAsAdmin' argument #839

Closed
emtuls opened this issue Jan 17, 2024 · 1 comment · Fixed by #840
Closed

VM-Install-Shortcut incorrectly uses 'RunAsAdmin' argument #839

emtuls opened this issue Jan 17, 2024 · 1 comment · Fixed by #840
Assignees
Labels
🐛 bug Something isn't working

Comments

@emtuls
Copy link
Member

emtuls commented Jan 17, 2024

What's the problem?

The function VM-Install-Shortcut is utilizing the RunAsAdmin argument for Install-ChocolatelyShortcut incorrectly leading to many unexpected issues such as:

  • Some shortcuts that are created automatically have the "Comment" section filled in with 'false' or 'true' (depending what was passed in), which displays when hovering over the shortcut
  • Every shortcut that is created will always be set to run as admin regardless of either $true or $false being passed in because the RunAsAdmin argument for Install-ChocolatelyShortcut is a switch rather than a bool.
  • There is sometimes the creation of a False directory in built_pkgs inside of the VM-Packages directory
  • Some shortcuts may have other things automatically set to "False" or "True" in their properties unintentionally
    • for example, the Start in: is set to "False" for hashmyfiles

This is because the RunAsAdmin argument is a switch, but we are treating it like a bool

Steps to Reproduce

Install any package that creates a shortcut and look at it's properties.

Environment

Environment independent.

@emtuls emtuls added the 🐛 bug Something isn't working label Jan 17, 2024
@Ana06 Ana06 added this to the FLARE-VM 2024 Q1 milestone Jan 17, 2024
@Ana06
Copy link
Member

Ana06 commented Jan 17, 2024

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants