Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Chrome as default for opening .html files #823

Closed
Ana06 opened this issue Jan 11, 2024 · 5 comments · Fixed by #1016
Closed

Set Chrome as default for opening .html files #823

Ana06 opened this issue Jan 11, 2024 · 5 comments · Fixed by #1016
Labels
💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed

Comments

@Ana06
Copy link
Member

Ana06 commented Jan 11, 2024

Details

@binjo has proposed a way to set Chrome to default for .html files in #779, but it doesn't work for me in an empty environment. @binjo's proposal uses https://github.com/DanysysTeam/PS-SFTA

I think we may want to add this to googlechrome.defaultbrowser.vm instead of to googlechrome.vm. Related: #822

@Ana06
Copy link
Member Author

Ana06 commented Jan 11, 2024

I think we should check with legal if the decide to include https://github.com/DanysysTeam/PS-SFTA in the repository.

@stevemk14ebr
Copy link
Contributor

It seems this is MIT licensed which makes me think it's ok legally

@Ana06
Copy link
Member Author

Ana06 commented Feb 16, 2024

It seems this is MIT licensed which makes me think it's ok legally

But the project does not include the MIT license. I am not sure if this an issue.

@stevemk14ebr
Copy link
Contributor

bottom of the readme says it's MIT which is enough

@emtuls
Copy link
Member

emtuls commented Apr 26, 2024

I just looked into this. This is mostly solved by the PR I just made here: #1016

We can use the new helper function: VM-Set-Open-With-Association <path to chrome> ".html", and after digging a bit deeper, I found that if we remove MSEdgeHTM from HKCU and HKLM, then it works. :)

I added it as a second commit to the PR

@emtuls emtuls linked a pull request Apr 26, 2024 that will close this issue
@Ana06 Ana06 removed the 😕 needs info Further information is needed label Jun 4, 2024
@Ana06 Ana06 added this to the FLARE-VM 2024 Q2 milestone Jun 4, 2024
@Ana06 Ana06 added the 💎 enhancement It is working, but it could be better label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants