Skip to content

Commit

Permalink
[daily] Do not update wiki and badge if failure
Browse files Browse the repository at this point in the history
Failures (such as a timeout error while testing the packages) are
causing the README badge to be updated wrongly. Change the conclusion status of the
package testing step to success even if packages fail, as the action is still
running as expected (we want to count the failures, so we expect
failures). This way we detect other errors early avoiding the wiki and
the badge to be updated.
  • Loading branch information
Ana06 committed Aug 26, 2024
1 parent f0f1dec commit 9e31358
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,29 +27,25 @@ jobs:
- name: Checkout code
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Build and test all packages
continue-on-error: true
run: scripts/test/test_install.ps1 -all -max_tries 3
- name: Upload logs to artifacts
uses: ./.github/actions/upload-logs
if: always()
- name: Checkout wiki code
if: always()
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
repository: ${{ github.repository }}.wiki
path: wiki
- name: Add results to wiki
if: always()
run: python scripts/utils/generate_daily_results.py ${{ github.repository }} ${{ github.sha }} ${{ github.run_number }} ${{ github.run_id }} ${{ matrix.os }}
- name: Commit changes
if: always()
working-directory: wiki
run: |
git config user.email '[email protected]'
git config user.name 'vm-packages'
git commit -am 'Add daily results'
git push
- name: Get badge info
if: always()
run: |
pwd
$json = Get-Content -Raw "success_failure.json" | ConvertFrom-Json
Expand All @@ -61,7 +57,6 @@ jobs:
echo "failure=$failure" >> $env:GITHUB_ENV
echo "message=$message" >> $env:GITHUB_ENV
- name: Update dynamic badge gist
if: always()
uses: schneegans/dynamic-badges-action@e9a478b16159b4d31420099ba146cdc50f134483 # v1.7.0
with:
auth: ${{ secrets.REPO_TOKEN }}
Expand Down

0 comments on commit 9e31358

Please sign in to comment.